Skip to content

Fix protocol enforcement#81

Merged
sepandhaghighi merged 1 commit intodevfrom
fix/protocol
May 8, 2026
Merged

Fix protocol enforcement#81
sepandhaghighi merged 1 commit intodevfrom
fix/protocol

Conversation

@AHReccese
Copy link
Copy Markdown
Member

Reference Issues/PRs

#78

What does this implement/fix? Explain your changes.

Any other comments?

…s to simplify URL handling by removing unnecessary protocol assignment and ensuring consistent encoding.
@AHReccese AHReccese added this to the mybutton v0.7 milestone May 3, 2026
@AHReccese AHReccese self-assigned this May 3, 2026
@AHReccese AHReccese added bug Something isn't working fix labels May 3, 2026
@AHReccese AHReccese changed the title Refactor urlValidation function in ShareModal and GetButton component… Fix protocol enforcement May 3, 2026
@AHReccese AHReccese requested a review from sepandhaghighi May 3, 2026 23:02
@AHReccese
Copy link
Copy Markdown
Member Author

@sepandhaghighi

Since the previous PR touched a large number of files, I wasn’t entirely sure how to update the changelog without making it overly verbose or noisy. I’d appreciate your guidance on the preferred approach. One option is to explicitly list all affected components/files (from this and the previous PR), but I’m not certain that level of granularity is desirable.

After this PR is merged, I plan to publish a new release, close all bug issues, and then proceed with the remaining items.

@sepandhaghighi sepandhaghighi merged commit d8f36fd into dev May 8, 2026
3 checks passed
@sepandhaghighi sepandhaghighi deleted the fix/protocol branch May 8, 2026 14:28
@sepandhaghighi
Copy link
Copy Markdown
Member

@sepandhaghighi

Since the previous PR touched a large number of files, I wasn’t entirely sure how to update the changelog without making it overly verbose or noisy. I’d appreciate your guidance on the preferred approach. One option is to explicitly list all affected components/files (from this and the previous PR), but I’m not certain that level of granularity is desirable.

There is no need to mention all components updates in the CHANGELOG.md. If we only mention the fixed bug, it is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants